Commit Graph

248 Commits

Author SHA1 Message Date
Nino Kodabande a927b6857f Merge branch 'vsco-fix-log-reopen-with-inotify' 2017-07-07 12:43:10 -07:00
Nino Kodabande 854fb55510 Resolves merge conflict in inotify 2017-07-07 12:41:52 -07:00
Nino Kodabande cd5bbb3d4d Merge pull request #112 from xuzixx/master
Issue 111: TestReSeekInotify failed
2017-07-07 12:19:11 -07:00
Nino Kodabande 2b56f8711f Merge pull request #105 from boz/fix-rl-gc-eviction
ratelimit: fix bucket collection eviction
2017-07-07 12:15:47 -07:00
Vlad Losev 2e79377851
Restores error propagation from fsnotify.Watcher.Add. 2017-03-20 18:08:26 -07:00
Vlad Losev 669c44045e
Fixes leak of watch counters in InotifyTracker.remove. 2017-03-20 17:50:07 -07:00
Vlad Losev a294104811
Disables file deleteion in TestReSeekInotify. 2017-03-19 17:39:19 -07:00
Vlad Losev b0c08f2030
Fixes log reopening. 2017-03-18 14:25:17 -07:00
xuzixx 89ee1afdf5 Issue 111: TestReSeekInotify failed
if "case fsnotify.Chmod" logic before "case fsnotify.Rename"
always `return changes.NotifyDeleted()`

Test case pass:
macOs 10.11.6 + go 1.6.2
Centos 6.4 + go 1.8
2017-03-05 18:55:54 +08:00
Nino Kodabande faf842bde7 Merge pull request #103 from aristanetworks/upstream
tail: Minor code cleanup.
2017-02-06 18:33:46 -08:00
Nino Kodabande 33107f39d5 Merge pull request #100 from bahlo/cleanup-error
Return error on tail.Cleanup
2017-02-06 18:32:04 -08:00
Nino Kodabande 46ed7f0315 Merge pull request #99 from arunmathew88/TailingStopBugFix
Tailing stop bug fix
2017-02-06 18:12:11 -08:00
Adam Bozanich 87e6317929 ratelimit: fix bucket collection eviction 2016-12-21 19:03:32 -08:00
Benoit Sigoure 74e17d03ab tail: Minor code cleanup.
Change-Id: Ib33db2c41cfd6117a9e9bfe64eab002f2b87331d
2016-12-13 17:06:15 -08:00
Nino Kodabande 915e5feba0 Merge pull request #101 from TerraTech/master
inotify.go: Fix bug where inotify returns IN_ATTRIB against an open fd when deleted
2016-11-25 10:17:10 -08:00
TerraTech bf39eb4f51 inotify.go: Fix bug where inotify returns IN_ATTRIB against an open fd 2016-09-09 01:07:24 -07:00
Arne Bahlo 9c97d7511f Return error on tail.Cleanup 2016-09-02 22:15:29 +02:00
Arun Mathew 48cd00098f Issue 97 Fixing deferred RemoveWatch() due to which tailing stops (gets stuck) in certain conditions 2016-08-01 15:58:52 +09:00
Arun Mathew 3ca1edc9ed Issue 98 Buffered channels to avoid lost NotifyDeleted()/NotifyTruncated()/NotifyModified() signals 2016-08-01 15:58:21 +09:00
Mark Yen a30252cb68 Merge pull request #89 from hpcloud/adds-appveyor-badge
adds appveyor badge to readme
2016-04-27 17:30:50 -07:00
Nino Khodabandeh 5d92327bc2 adds appveyor badge to readme 2016-04-27 17:16:43 -07:00
Mark Yen c323fd4fa9 Merge pull request #88 from hpcloud/add-appveyor-for-windows
Adds appveyor for windows build
2016-04-27 16:59:03 -07:00
Nino Khodabandeh 166d4e4826 Adds appveyor for windows build 2016-04-27 16:29:40 -07:00
Nino Khodabandeh fff2f2d9e0 Merge pull request #85 from hpcloud/update-licensing
Updates licensing and all the header comments
2016-04-26 17:15:55 -07:00
Mark Yen 9d956fd2bb Merge pull request #84 from hpcloud/fix-flaky-test
Fixes flaky / buggy tests
2016-04-26 16:37:49 -07:00
Nino Khodabandeh 865a91f509 Fixes wrong formatting 2016-04-26 16:30:13 -07:00
Nino Khodabandeh 86ea7df4bc Check of the content of the line 2016-04-26 16:16:15 -07:00
Nino Khodabandeh 34db8a6edf Updates licensing and all the header comments 2016-04-26 15:47:46 -07:00
Nino Khodabandeh a7c1263528 Fixes flaky test
- Added a non blocking method to read tail lines for test assertion
- Minor clean up
2016-04-26 15:21:54 -07:00
Nino Khodabandeh 26dc82c746 Wait for done chan first before Cleanup 2016-04-26 12:23:22 -07:00
Nino Khodabandeh 308ca46680 This Change includes:
- Fixes Flaky test, some tests do not require call to tail.Stop()
- Changes inadequate names
2016-04-26 11:30:20 -07:00
Nino Khodabandeh 04356b27e1 Merge branch 'davidsansome-block-until-exists-relative-path' 2016-04-26 10:57:50 -07:00
Nino Khodabandeh 425bce90fd Merge branch 'block-until-exists-relative-path' of https://github.com/davidsansome/tail into davidsansome-block-until-exists-relative-path 2016-04-26 10:56:05 -07:00
miraclesu b2940955ab fix reader nil pointer 2016-04-14 17:05:39 -07:00
Nino Khodabandeh adca23eea0 Merge pull request #76 from aristanetworks/upstream
Fix deadlock when watching files with inotify
2016-04-08 16:33:03 -07:00
Benoit Sigoure 5e2d004af5 watch: Fix prototype to be more restrictive.
Change-Id: Ic744312efa91cf5c2dc2810e597353a080dccb70
2016-04-08 16:29:40 -07:00
Benoit Sigoure ac5972aca8 watch: Unsubscribe from fsnotify synchronously.
Calling watcher.Remove() from the run() goroutine is now problematic,
because with the change made in fsnotify/fsnotify#73 Remove() can now
take an arbitrary amount of time, which means we can deadlock if run()
is waiting for fsnotify to acknowledge the removal and fsnotify is
trying to send an unrelated Event.

So instead we now do part of the cleanup, including calling Remove(),
synchronously, in the goroutine trying to unsubscribe.

This fixes #75.  Thanks to Aaron Beitch for the fix.

Change-Id: I346c9eecc34b2378312b07b3c3efc41616b95380
2016-04-08 16:29:40 -07:00
Mark Yen f4e2250826 Merge pull request #81 from hpcloud/fix-race-in-test
Fixes race in test
2016-04-08 12:58:07 -07:00
Nino Khodabandeh b58ee27c66 Fixes race in test
- Enabled race flag in the make file to alway run with -race locally
- Moved polling interval into TestMain to avoid race
2016-04-08 11:47:25 -07:00
Mark Yen 3b00e857b6 Merge pull request #80 from hpcloud/v2-criteria
Support golang 1.6; move to vendoring.
2016-04-07 16:54:25 -07:00
Nino Khodabandeh 08067f95ff Fixes go import
- changed dotted import in tail_test since it was causing suite failure
2016-04-07 16:41:16 -07:00
Nino Khodabandeh 665473a0d8 Updated Changes.md and travis.yml
- Included the godep migration and vendoring folder into changes.md
- Updated travis.yml to deprecate support for golang 1.3
- Added 1.6 and tip run to travis.yml
2016-04-07 16:21:17 -07:00
Nino Khodabandeh 0e7c7c1aee Godep workspace -> vendor directory 2016-04-07 16:14:15 -07:00
Nino Khodabandeh 9e6542941b Merge branch 'tcheneau-typo-fix' 2016-04-06 16:25:08 -07:00
Nino Khodabandeh d777a48bf8 Merge branch 'typo-fix' of https://github.com/tcheneau/tail into tcheneau-typo-fix 2016-04-06 16:23:43 -07:00
Mark Yen d149232c39 Merge pull request #79 from hpcloud/add-godep
Adds godep, and removes depman since deprecated
2016-04-06 16:13:43 -07:00
Nino Khodabandeh 1763ddcc04 Adds godep, and removes depman since deprecated 2016-04-06 11:26:07 -07:00
Nino Khodabandeh 2e817490f9 Merge branch 'ando-masaki-master' 2016-04-04 15:53:00 -07:00
Nino Khodabandeh 0ea51b0fd6 Changes the path clean to absolute path 2016-04-04 15:51:37 -07:00
Nino Khodabandeh e43dce6dc1 Merge branch 'flynn-stop-at-eof' 2016-04-04 12:57:23 -07:00