Commit Graph

229 Commits

Author SHA1 Message Date
Nino Khodabandeh b2c9cdec99 Merge pull request #58 from aristanetworks/upstream
Single shared Watcher used to avoid inotify limit
2015-10-28 08:39:08 -07:00
Benoit Sigoure f69ef84e36 Fix race in the detection of truncation.
Before going into ChangeEvents(), the code was calling stat on the file
to know where it was at, which is incorrect as stat could return the new
file size post truncation.  Instead we now ask the file descriptor about
our current offset, so we can compare our offset to the file size to try
to detect truncation.

Truncation detection remains brittle, but this closes an annoying race
we frequently run into.
2015-10-27 22:42:26 -07:00
Alex Liu abb1479f04 Remove pointer from fsnotify.Event 2015-10-27 22:42:26 -07:00
Alex Liu 8b4773e24e Upgrade to fsnotify.v1 2015-10-27 22:42:25 -07:00
Andy Ouyang d46611791d Moved InotifyTracker initialization to constructor function 2015-10-27 22:42:25 -07:00
Andy Ouyang a5dc0d39ba Ensure InotifyTracker attempts to send all FileEvents 2015-10-27 22:42:25 -07:00
Andy Ouyang f053e2cd0c Fixed race conditions in watch/inotify_tracker.go 2015-10-27 22:42:25 -07:00
Andy Ouyang 0b9f044bb3 Ignoring EINTR (ctrl+Z) signal 2015-10-27 22:42:25 -07:00
Andy Ouyang b155fc13d4 Single shared Watcher used to avoid inotify limit 2015-10-27 22:42:07 -07:00
Nino Khodabandeh 213cadfb2e Merge pull request #63 from ekini/master
Make Logger an interface, so external logger can be used, closes #52
2015-10-27 22:38:56 -07:00
Eugene Dementiev 8dfe0aa72f Make Logger an interface, so external logger can be used, closes #52 2015-10-05 11:56:25 +03:00
Nino Khodabandeh 05d326f717 Merge pull request #62 from florindragos/master
Treat permission error as if file was deleted on windows
2015-09-30 10:56:01 -07:00
Nino Khodabandeh 9ca2efc54b Merge pull request #32 from 0x001D/master
detect file size modification for polling
2015-09-30 10:46:22 -07:00
Florin Dragos 2403cad5eb Fix imports 2015-09-30 17:50:49 +03:00
Florin Dragos d9f4dcdb25 Treat permission error as if file was deleted on windows 2015-09-29 17:32:21 +03:00
David Sansome e681532458 Watch the *directory* for file deletions instead of the file itself.
inotify works on the inode, not the path.  Deleting the file doesn't
touch the inode, so doesn't generate an event on the file.

Fixes #57
2015-09-29 21:41:27 +10:00
David Sansome 760f3e6edc Fix BlockUntilExists for relative paths.
filepath.Dir("foo") returns ".", so the inotify events are of the form
"./foo", which is not equal to the filename being watched ("foo")
2015-09-29 21:41:22 +10:00
David Sansome 0da4e86639 Wait for goroutines to finish before leaving test functions.
VerifyTailOutput is started in a goroutine, but the test function
doesn't wait for this goroutine to exit before returning, so any errors
raised by VerifyTailOutput after the function returns are lost.

Also add a failing test for tailing a file with a relative path.
2015-09-29 21:33:56 +10:00
Wim 52a42ed990 Do not seek in named pipe 2015-09-24 21:40:43 +02:00
Sridhar Ratnakumar 4b368d1590 Merge pull request #56 from ActiveState/travis-gopkg-fix
Workaround travis failures around gopkg.in imports. Also use latest Go versions to test.
2015-07-03 16:30:24 -07:00
Sridhar Ratnakumar 8772f68b05 Test against latest Go versions in travis 2015-07-03 16:26:59 -07:00
Sridhar Ratnakumar 55f91c7879 Workaround travis failures around gopkg.in imports
By manually installing it.
2015-07-03 16:26:01 -07:00
Sridhar Ratnakumar 0bf705ac46 solicit help with Windows support 2015-07-03 16:19:37 -07:00
Sridhar Ratnakumar f3fe9b76bd change log entry for last PR 2015-07-03 14:27:12 -07:00
Sridhar Ratnakumar b1f6c8f553 Merge pull request #53 from wagerlabs/v1
Single inotify instance with multiple watchers
2015-07-03 14:23:58 -07:00
Joel Reymont 244ac5d165 use the single tracker instance 2015-07-03 16:53:42 +02:00
Joel Reymont 48bc495430 minor 2015-07-03 16:53:13 +02:00
Joel Reymont f96904ede7 go fmt 2015-07-03 16:51:41 +02:00
Joel Reymont 035761b7bc one watcher 2015-07-03 16:35:40 +02:00
Sridhar Ratnakumar 15e71d383e Use stable version of fsnotify
fixes #46
2015-06-28 20:23:06 -07:00
Sridhar Ratnakumar 4d381fccb0 Modernize Dockerfile to use the golang image 2015-06-28 20:19:59 -07:00
Sridhar Ratnakumar d88c762aa1 Fix 'make fulltest' for newer docker versions 2015-06-28 20:15:57 -07:00
Sridhar Ratnakumar c865311314 Update CHANGES.md 2015-06-17 16:00:46 -07:00
Sridhar Ratnakumar f9f753ab01 Merge pull request #50 from featalion/newline-fix
PR #40 with test case

closes #35 and closes #40
2015-06-17 15:59:14 -07:00
Yury Yantsevich fe151849bb split max line size test to follow and nofollow version 2015-06-17 16:59:08 +02:00
Yury Yantsevich 50aa2240d2 Merge branch 'half-lines-fix' of https://github.com/2sidedfigure/tail into newline-fix 2015-06-17 15:49:11 +02:00
Jonathan Rudenberg 166cd27854 Add StopAtEOF to stop tailing when the end of the file is reached 2014-12-25 21:02:30 -05:00
Jonathan Rudenberg 0587510d19 Remove Close method from FileChanges
This method will never do what we want, closing the channels will always
signal receivers, which will confuse them.
2014-12-25 21:02:30 -05:00
Sridhar Ratnakumar 068b72961a Merge pull request #41 from kouk/master
support freebsd, like darwin
2014-10-08 12:42:06 -07:00
Konstantinos Koukopoulos d20f005e95 support freebsd, like darwin 2014-10-08 12:37:29 +03:00
2sidedfigure 83adfd1168 Don't return lines not ending in a newline when following 2014-08-15 13:49:26 -07:00
Sridhar Ratnakumar fd3ba4e64c Merge pull request #38 from rickard-von-essen/posix
[GH-37] Support Darwin (OS X) again
2014-07-28 15:34:07 -07:00
Rickard von Essen ed4080883b [GH-37] Support Darwin (OS X) again 2014-07-29 00:29:01 +02:00
Sridhar Ratnakumar 6d888fbada changelog for last PR 2014-07-28 13:45:56 -07:00
Sridhar Ratnakumar 5fc9335f68 Merge pull request #36 from UhuruSoftware/master
Fix tail for windows os
2014-07-28 13:45:15 -07:00
florindragos c2a48be739 add FILE_SHARE_DELETE flag when opening file 2014-07-28 16:38:02 +03:00
Sridhar Ratnakumar 22e519566e Fix tomb import
has moved from launchpad.net (now down) to GitHub, and accessible as
gopkg.in/tomb.v1

closes #33
2014-06-14 23:39:34 -07:00
0x001D 604d99043e detect file size modification for polling
polling did not work (at least for a win32 environment)
2014-06-12 00:22:14 +02:00
Sridhar Ratnakumar 056d606881 Update CHANGES.md 2014-05-20 17:49:42 -07:00
Sridhar Ratnakumar c5d5673bde Merge pull request #30 from ActiveState/odd_line_splitting
Fix odd line splitting
2014-05-20 17:49:00 -07:00