f69ef84e36
Fix race in the detection of truncation.
...
Before going into ChangeEvents(), the code was calling stat on the file
to know where it was at, which is incorrect as stat could return the new
file size post truncation. Instead we now ask the file descriptor about
our current offset, so we can compare our offset to the file size to try
to detect truncation.
Truncation detection remains brittle, but this closes an annoying race
we frequently run into.
2015-10-27 22:42:26 -07:00
abb1479f04
Remove pointer from fsnotify.Event
2015-10-27 22:42:26 -07:00
8b4773e24e
Upgrade to fsnotify.v1
2015-10-27 22:42:25 -07:00
d46611791d
Moved InotifyTracker initialization to constructor function
2015-10-27 22:42:25 -07:00
b155fc13d4
Single shared Watcher used to avoid inotify limit
2015-10-27 22:42:07 -07:00
2403cad5eb
Fix imports
2015-09-30 17:50:49 +03:00
48bc495430
minor
2015-07-03 16:53:13 +02:00
035761b7bc
one watcher
2015-07-03 16:35:40 +02:00
15e71d383e
Use stable version of fsnotify
...
fixes #46
2015-06-28 20:23:06 -07:00
22e519566e
Fix tomb import
...
has moved from launchpad.net (now down) to GitHub, and accessible as
gopkg.in/tomb.v1
closes #33
2014-06-14 23:39:34 -07:00
6ffcd854c1
run 'go fmt' (and fix 'make fmt' in Makefile)
2013-11-13 17:38:23 -08:00
323e1c0988
add Cleanup function to close open inotify watches
...
bug: 101635
2013-11-12 20:15:27 -08:00
56c4b221b8
replace the alarmist panic with Fatal
...
Fatal shows only a single goroutine stacktrace.
2013-10-11 18:19:43 -07:00
88298d7cf8
Merge pull request #18 from miraclesu/fix_stop_hang
...
Fix a hang in `Stop` when tailing a non-existent file
Reproducible on linux, but not on mac.
2013-09-23 18:19:18 -07:00
a7f9b4b6fc
Fixed stop hang & stop err
2013-09-23 15:03:51 +08:00
afd80c034c
fix race/panic on modify+delete
...
This fixes a race condition when a file is modified and unlinked in the OS before the inotify IsModify event has a chance to call os.Stat.
2013-09-22 22:51:12 -04:00
68dffd22b4
fix a regression with truncation detection
2013-05-29 15:08:24 -07:00
499e541b19
copytruncate should work even if ReOpen is False.
...
at least, `tail -f` (not `tail -F` which is analogous to ReOpen)
reopens truncated files.
this change introduces the FileChanges struct to abstract the change
notifications for file changes, deletions and truncations.
2013-05-29 14:32:59 -07:00
d3c80d385d
refactor code for upcoming changes to tail.go
2013-05-29 13:57:02 -07:00
2cddd48e0a
clean up ChangeEvents' goroutines upon tail.Stop
2013-05-29 11:35:27 -07:00
7599e3efb9
fix tail.Stop blocking when called in midst of re-opening
...
this is what caused the test to hang occasionally. after this fix,
test completes in 2mins all the time.
closes issue #4
2013-05-28 19:35:12 -07:00
0f67bc352f
make watch.go its own package
...
for the purpose for upcoming changes to the watch functionality.
2013-05-28 16:37:21 -07:00
Benoit Sigoure
Alex Liu
Andy Ouyang
Florin Dragos
Joel Reymont
Sridhar Ratnakumar
Sridhar Ratnakumar
Sridhar Ratnakumar
miraclesu
presbrey