d3c80d385d
refactor code for upcoming changes to tail.go
2013-05-29 13:57:02 -07:00
2cddd48e0a
clean up ChangeEvents' goroutines upon tail.Stop
2013-05-29 11:35:27 -07:00
7599e3efb9
fix tail.Stop blocking when called in midst of re-opening
...
this is what caused the test to hang occasionally. after this fix,
test completes in 2mins all the time.
closes issue #4
2013-05-28 19:35:12 -07:00
0f67bc352f
make watch.go its own package
...
for the purpose for upcoming changes to the watch functionality.
2013-05-28 16:37:21 -07:00
b664e9fc9d
Merge pull request #6 from srid/bug99139_copytruncate
...
copytruncate support,
truncation detection for both inotify and polling file watchers along with test cases, plus a fix for issue #5 .
2013-05-28 14:03:12 -07:00
976fc15b81
update change log, gofmt and remove debug prints
2013-05-28 14:01:32 -07:00
644891ebbc
BlockUntilExists should return immediately if the file already exists
...
this fixes a potential race condition in the use of BlockUntilExists
following a file existence check (as we do in tail.go:reopen).
closes issue 5
2013-05-28 13:29:40 -07:00
fb37e0b7ca
use a smaller poll duration for faster test runs
2013-05-28 12:55:11 -07:00
c90cd7b8db
add truncation detection to PollingFileWatcher
2013-05-28 12:54:53 -07:00
5ccafcc3d6
fixes on top of Florian's truncation detection ( 1ff299bc2)
...
* initialize `Size` with the then-size of the file when ChangeEvents
is called. remember that this function is expected to be called many
times, one after another. this also passes the TestReSeekInotify
test.
* do not ignore errors from os.Stat. we panic errors like these now,
but ideally should switch to tomb.Tomb for letting the user handle
them.
2013-05-28 12:31:46 -07:00
8c443fb067
fix truncation tests
...
* use O_TRUNC to actually truncate
* use longer initial data before truncating
truncated and updated file is expected to be of smaller size, else
truncation detection won't work.
ref: https://github.com/josegonzalez/beaver/pull/67/files
2013-05-28 12:28:56 -07:00
1ff299bc29
Add support for file truncation in InotifyFileWatcher
...
(cherry picked from commit 9de77aad8caca8102e7dd7c936d00ca3f0421ca7)
2013-05-28 11:59:03 -07:00
e9c3c07fbb
add (failing) tests for copytruncate detection
2013-05-28 11:46:49 -07:00
ad34bda357
Merge pull request #3 from srid/bug99126_rotation_when_polling
...
Make tail work with file rotation when using polling file watcher
2013-05-28 11:07:12 -07:00
6260efacf3
add change log
2013-05-28 11:06:11 -07:00
39e5784aed
allow compilation on Go1
2013-05-28 10:52:38 -07:00
1336a0e4ab
remove a redundant goroutine
2013-05-27 15:41:33 -07:00
ec461b87f0
implement PollingFileWatcher.BlockUntilExists
2013-05-27 15:34:50 -07:00
c5073c7f26
PollingFileWatcher.ChangeEvents must detect file deletion/rename
2013-05-27 15:34:50 -07:00
e895d422e1
run TestReOpen with both poll = true and false
...
this catches a bug with log rotation when using polling file watcher.
2013-05-27 15:32:49 -07:00
bf1dd37666
fix comments for godoc
2013-03-10 15:17:00 -07:00
7369ae5fd4
README: link to API docs
2013-03-10 15:01:42 -07:00
f2cd234400
fix README example
2013-02-05 18:49:32 -08:00
835af806b3
update README -- this is a library, not a program
2013-02-04 18:59:04 -08:00
de037b033d
allow the user to control the GOPATH
2013-01-07 12:56:25 -08:00
0449e85ca5
add license and copyright
2013-01-07 12:54:49 -08:00
7451ac9176
install instructions in README
2013-01-07 12:51:30 -08:00
94b64e81e8
move Go repos to ActiveState org
2012-12-14 05:00:55 -08:00
2384ff6374
avoid unnecessary inotify warning
2012-11-27 11:11:10 -08:00
a500d8777b
fix import path for the executable code
2012-11-23 12:27:28 -08:00
683e11c27d
expose the time object to allow custom formatting
...
ref - http://bugs.activestate.com/show_bug.cgi?id=96009
2012-10-29 19:53:48 -07:00
989b0425dc
remove logyard references and update README
...
also fix local gopath
2012-10-17 11:56:54 -07:00
1a694c85a6
test refactoring: use struct embedding to reuse semantics
2012-10-13 13:04:50 -07:00
b8bf75b80a
MaxLineSize now splits longer lines without discarding the rest
...
implements http://bugs.activestate.com/show_bug.cgi?id=95745
2012-10-13 12:50:27 -07:00
d214cebdfd
test case for "-F" (follow by name)
...
-F mode reopens deleted/ renamed files.
2012-10-13 12:11:50 -07:00
aa3b7c3413
test: add test for "-n 0"
2012-10-13 12:02:38 -07:00
df3f97310f
test: fixture workflow to make test functions concise
2012-10-13 11:44:47 -07:00
4e53f618e2
first test case for tail
...
tests "-n -1"
need to abstract operations for multiple workflow
2012-10-13 11:20:04 -07:00
dfe0ea8ba5
optimize polling watcher using stat check
...
does not send 'changed' events if the last modified time hasn't changed.
2012-10-12 18:12:49 -07:00
adcb2e389d
fix: BlockUntilExists should only return if filename matches
2012-10-12 17:30:45 -07:00
507783a4a0
allow gotail to accept multiple files
...
also rename cmd/tail to cmd/gotail
2012-10-12 17:28:04 -07:00
048bbf8933
introduce tail command; fix tomb blocking after Kill
2012-10-12 17:14:35 -07:00
4bbf3d28cc
gracefully manage goroutines death using tomb
...
http://blog.labix.org/2011/10/09/death-of-goroutines-under-control
2012-10-12 16:28:22 -07:00
187dea7196
use struct to configure the growing tail args; start working on unit tests
2012-10-12 14:32:04 -07:00
f7193d4658
start working on tail's readme/example
2012-10-12 09:05:11 -07:00
74f84016b8
close the inotify watcher when returning
...
might fix http://bugs.activestate.com/show_bug.cgi?id=95803#c12
2012-10-12 07:09:36 -07:00
5c84486ca3
check the stop channel while waiting on inotify
...
fixes http://bugs.activestate.com/show_bug.cgi?id=95718#c3
2012-10-11 21:47:58 -07:00
3ff602e781
Bug #95803 - reduce cpu usage due to frequent polling
...
* use inotify for system log aggregation
* continue using polling for app log aggregation (overlayfs bug)
* but increase wait time to 250ms
Squashed commit of the following:
commit 8ccd0359e559472be0066ad889ac1772e13ff20b
Author: Sridhar Ratnakumar <sridharr@activestate.com>
Date: Thu Oct 11 21:28:41 2012 -0700
complete the polling watcher
commit 0a5d5aa488e96aa247c7c88c25cd5a30219f5344
Author: Sridhar Ratnakumar <sridharr@activestate.com>
Date: Thu Oct 11 20:50:08 2012 -0700
hackish, untested, incomplete implementation of pollig filewatcher
.. to be tested on macbook.
commit c7ac3851452ed23a8b099773cc9c9f23734a89f5
Author: Sridhar Ratnakumar <sridharr@activestate.com>
Date: Thu Oct 11 15:45:59 2012 -0700
tail: use inotify instead of polling
reduces cpu usage and fixes Bug #95803
2012-10-11 21:29:35 -07:00
6a5092ff5c
Bug #95787 : warn and ignore tailing app logs if their base dir (container) goes away fast
...
.. but not for system logs as we expect /s/logs/ to exist.
2012-10-10 15:13:13 -07:00
99fe83b742
make tail.go its own package, independent of logyard
2012-10-09 15:13:05 -07:00
Sridhar Ratnakumar
Sridhar Ratnakumar
Florian Weingarten