Commit Graph

251 Commits

Author SHA1 Message Date
Nino Khodabandeh 2e817490f9 Merge branch 'ando-masaki-master' 2016-04-04 15:53:00 -07:00
Nino Khodabandeh 0ea51b0fd6 Changes the path clean to absolute path 2016-04-04 15:51:37 -07:00
Nino Khodabandeh e43dce6dc1 Merge branch 'flynn-stop-at-eof' 2016-04-04 12:57:23 -07:00
Nino Khodabandeh 468784e1d4 Merge branch 'stop-at-eof' of https://github.com/flynn/tail into flynn-stop-at-eof 2016-04-04 12:56:46 -07:00
Tony Cheneau 2f69c9fa4e Fix typo (colseFile -> closeFile) 2016-04-04 16:51:26 +02:00
Benoit Sigoure 6c6f39c586 watch: Fix prototype to be more restrictive.
Change-Id: Ic744312efa91cf5c2dc2810e597353a080dccb70
2016-03-01 10:05:21 -08:00
Benoit Sigoure d5f9e6c087 tail: Fix tyop.
Change-Id: I0f9b88fc327b169c748794e86efb0aa0a03b3e2a
2016-03-01 10:05:19 -08:00
Benoit Sigoure 0bc5f080e8 watch: Unsubscribe from fsnotify synchronously.
Calling watcher.Remove() from the run() goroutine is now problematic,
because with the change made in fsnotify/fsnotify#73 Remove() can now
take an arbitrary amount of time, which means we can deadlock if run()
is waiting for fsnotify to acknowledge the removal and fsnotify is
trying to send an unrelated Event.

So instead we now do part of the cleanup, including calling Remove(),
synchronously, in the goroutine trying to unsubscribe.

This fixes #75.  Thanks to Aaron Beitch for the fix.

Change-Id: I346c9eecc34b2378312b07b3c3efc41616b95380
2016-03-01 10:05:17 -08:00
Nino Khodabandeh 1a0242e795 Merge pull request #72 from miraclesu/fix/watch_create
fix block until exists function
2016-01-19 12:44:47 -08:00
miraclesu 44f3947385 Add race detection on Travis CI 2016-01-05 10:07:56 +08:00
miraclesu 089d8456a7 test in go1.5.2 2015-12-24 17:50:07 +08:00
miraclesu 274567a526 fix data race 2015-12-24 16:47:46 +08:00
Nino Khodabandeh 272d489eea Update README.md
Points build status to a correct url
2015-12-18 15:33:59 -08:00
miraclesu 2bc904e34f colse file just one time 2015-12-09 16:38:19 +08:00
miraclesu 6aef373ea6 fix block until exists function 2015-12-09 15:29:06 +08:00
Nino Khodabandeh 157f8ef18f Merge branch 'ajacoutot-openbsd' 2015-11-02 12:50:03 -08:00
Nino Khodabandeh 9e7c303211 Merge branch 'openbsd' of https://github.com/ajacoutot/tail into ajacoutot-openbsd 2015-11-02 12:49:12 -08:00
Nino Khodabandeh 5ef9f2ea8d Merge pull request #66 from ober/master
Add NetBSD support.
2015-11-02 10:42:57 -08:00
Antoine Jacoutot c05830b483 Build tail_posix on openbsd as well. 2015-10-31 11:02:26 +01:00
Jaime Fournier de15be56e0 add netbsd 2015-10-28 18:28:02 -07:00
Nino Khodabandeh 0f289693ec Merge branch '42wim-namedpipe' 2015-10-28 10:03:00 -07:00
Nino Khodabandeh 71a3d44347 Merge branch 'namedpipe' of https://github.com/42wim/tail into 42wim-namedpipe 2015-10-28 10:02:44 -07:00
Nino Khodabandeh b2c9cdec99 Merge pull request #58 from aristanetworks/upstream
Single shared Watcher used to avoid inotify limit
2015-10-28 08:39:08 -07:00
Benoit Sigoure f69ef84e36 Fix race in the detection of truncation.
Before going into ChangeEvents(), the code was calling stat on the file
to know where it was at, which is incorrect as stat could return the new
file size post truncation.  Instead we now ask the file descriptor about
our current offset, so we can compare our offset to the file size to try
to detect truncation.

Truncation detection remains brittle, but this closes an annoying race
we frequently run into.
2015-10-27 22:42:26 -07:00
Alex Liu abb1479f04 Remove pointer from fsnotify.Event 2015-10-27 22:42:26 -07:00
Alex Liu 8b4773e24e Upgrade to fsnotify.v1 2015-10-27 22:42:25 -07:00
Andy Ouyang d46611791d Moved InotifyTracker initialization to constructor function 2015-10-27 22:42:25 -07:00
Andy Ouyang a5dc0d39ba Ensure InotifyTracker attempts to send all FileEvents 2015-10-27 22:42:25 -07:00
Andy Ouyang f053e2cd0c Fixed race conditions in watch/inotify_tracker.go 2015-10-27 22:42:25 -07:00
Andy Ouyang 0b9f044bb3 Ignoring EINTR (ctrl+Z) signal 2015-10-27 22:42:25 -07:00
Andy Ouyang b155fc13d4 Single shared Watcher used to avoid inotify limit 2015-10-27 22:42:07 -07:00
Nino Khodabandeh 213cadfb2e Merge pull request #63 from ekini/master
Make Logger an interface, so external logger can be used, closes #52
2015-10-27 22:38:56 -07:00
Eugene Dementiev 8dfe0aa72f Make Logger an interface, so external logger can be used, closes #52 2015-10-05 11:56:25 +03:00
Nino Khodabandeh 05d326f717 Merge pull request #62 from florindragos/master
Treat permission error as if file was deleted on windows
2015-09-30 10:56:01 -07:00
Nino Khodabandeh 9ca2efc54b Merge pull request #32 from 0x001D/master
detect file size modification for polling
2015-09-30 10:46:22 -07:00
Florin Dragos 2403cad5eb Fix imports 2015-09-30 17:50:49 +03:00
Florin Dragos d9f4dcdb25 Treat permission error as if file was deleted on windows 2015-09-29 17:32:21 +03:00
David Sansome e681532458 Watch the *directory* for file deletions instead of the file itself.
inotify works on the inode, not the path.  Deleting the file doesn't
touch the inode, so doesn't generate an event on the file.

Fixes #57
2015-09-29 21:41:27 +10:00
David Sansome 760f3e6edc Fix BlockUntilExists for relative paths.
filepath.Dir("foo") returns ".", so the inotify events are of the form
"./foo", which is not equal to the filename being watched ("foo")
2015-09-29 21:41:22 +10:00
David Sansome 0da4e86639 Wait for goroutines to finish before leaving test functions.
VerifyTailOutput is started in a goroutine, but the test function
doesn't wait for this goroutine to exit before returning, so any errors
raised by VerifyTailOutput after the function returns are lost.

Also add a failing test for tailing a file with a relative path.
2015-09-29 21:33:56 +10:00
Wim 52a42ed990 Do not seek in named pipe 2015-09-24 21:40:43 +02:00
Sridhar Ratnakumar 4b368d1590 Merge pull request #56 from ActiveState/travis-gopkg-fix
Workaround travis failures around gopkg.in imports. Also use latest Go versions to test.
2015-07-03 16:30:24 -07:00
Sridhar Ratnakumar 8772f68b05 Test against latest Go versions in travis 2015-07-03 16:26:59 -07:00
Sridhar Ratnakumar 55f91c7879 Workaround travis failures around gopkg.in imports
By manually installing it.
2015-07-03 16:26:01 -07:00
Sridhar Ratnakumar 0bf705ac46 solicit help with Windows support 2015-07-03 16:19:37 -07:00
Sridhar Ratnakumar f3fe9b76bd change log entry for last PR 2015-07-03 14:27:12 -07:00
Sridhar Ratnakumar b1f6c8f553 Merge pull request #53 from wagerlabs/v1
Single inotify instance with multiple watchers
2015-07-03 14:23:58 -07:00
Joel Reymont 244ac5d165 use the single tracker instance 2015-07-03 16:53:42 +02:00
Joel Reymont 48bc495430 minor 2015-07-03 16:53:13 +02:00
Joel Reymont f96904ede7 go fmt 2015-07-03 16:51:41 +02:00